New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs a special case for links at/near the top of pages #77

Closed
Jaitsu opened this Issue Nov 6, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@Jaitsu
Copy link

Jaitsu commented Nov 6, 2014

I'm loving the extension otherwise, but I'm finding that links at the top of the page are impossible to click. The toolbar that pops down and shows the URL of the link blocks the link, creating an endless loop of it appearing and disappearing as it steals focus from the link, and then disappears since the link that summoned it no longer has hover focus, then reappears since the link is unblocked again.

Making it transparent (to clicks and hovers, too) might help in these cases if possible.

@Quicksaver

This comment has been minimized.

Copy link
Owner

Quicksaver commented Nov 6, 2014

I assume you have some other add-on that shows the link url in the location bar?

@Jaitsu

This comment has been minimized.

Copy link

Jaitsu commented Nov 6, 2014

...oh whoops. My bad, sorry. Yeah, Link Location Bar. I forgot that wasn't default functionality.

https://addons.mozilla.org/en-US/firefox/addon/link-location-bar/ is the add-on in question. I don't know if you're supporting other add-ons like this or not. I suppose TFOF makes the other kind of obsolete anyway since the idea was to minimize screen clutter...

@Quicksaver

This comment has been minimized.

Copy link
Owner

Quicksaver commented Nov 6, 2014

Yes I do support it, the add-on already has a few fixes for LLB even. ;)

I hadn't considered links at the very top of the page though, could you give me an example of a page like this? I'm going to see what I can do about it, if I can find a fix or a workaround for this case I will add it of course.

@Jaitsu

This comment has been minimized.

Copy link

Jaitsu commented Nov 6, 2014

...Okay good I feel like a bit less of a moron now

Anyway, http://reddit.com is one example with its My Subreddits list up top, or even right here on Github with things like the Explore button up top.

@Quicksaver

This comment has been minimized.

Copy link
Owner

Quicksaver commented Nov 22, 2014

Can you try beta version 1.1.7b1 at the top of https://addons.mozilla.org/firefox/addon/the-fox-only-better/versions/ please and tell me what you think?

In that version I changed a bit the behavior when Link Location Bar is enabled. The mini bar will only extend up to half of the available width when previewing a link, and if you move the mouse to it, it will jump to the opposite side of the window, so that you can access the links below it. Note that this will only happen when previewing links with the Link Location Bar add-on, the normal mini bar (such as in when a password field is focused) will still behave as before and won't jump to the other side if moused over.

@Jaitsu

This comment has been minimized.

Copy link

Jaitsu commented Nov 22, 2014

Aha, that's much better. Still see a little flicker before it jumps to the other side, but this is much better and keeps it from getting in the way.

@Quicksaver

This comment has been minimized.

Copy link
Owner

Quicksaver commented Nov 22, 2014

Yeah it does that, but it's probably not something I can get rid of so easily, because it has to wait until the mini bar is shown before it knows if it has to move it or not; it would take a lot of following the mouse around to do this without this flicker, and that can become very processor-intensive. But since it's such a minor thing I hope it isn't very bothersome. :) But do let me know if you think it bothers you, and I'll see what I can do about that flicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment