Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-international): use a regex to allow multiple interpolations #30

Merged
merged 2 commits into from Aug 19, 2022

Conversation

cstrnt
Copy link
Contributor

@cstrnt cstrnt commented Aug 19, 2022

Right now it`s not possible to use a translation text that uses the same variable more than once, because only the first instance will be interpolated

@QuiiBz
Copy link
Owner

QuiiBz commented Aug 19, 2022

Thanks for the PR! The only issue is that IE11 doesn't support replaceAll (but Next.js supports IE11, so we should do the same) - I think we can maybe use a regex with replace instead?

@cstrnt
Copy link
Contributor Author

cstrnt commented Aug 19, 2022

Thanks for the PR! The only issue is that IE11 doesn't support replaceAll (but Next.js supports IE11, so we should do the same) - I think we can maybe use a regex with replace instead?

Just updated

@QuiiBz QuiiBz changed the title feat(next-international): use replaceAll to allow multiple interpolations feat(next-international): use a regex to allow multiple interpolations Aug 19, 2022
Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@QuiiBz QuiiBz merged commit 86dd594 into QuiiBz:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants