Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --fix option to autofix issues #6

Closed
QuiiBz opened this issue Sep 19, 2023 · 2 comments · Fixed by #14
Closed

feat: add --fix option to autofix issues #6

QuiiBz opened this issue Sep 19, 2023 · 2 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@QuiiBz
Copy link
Owner

QuiiBz commented Sep 19, 2023

As suggested by @juliusmarminge: https://twitter.com/jullerino/status/1703794047104479562

We should add support for a new --fix option, that will try to fix issues as much as possible. We can add a fn fix(&self) -> bool to the Issue trait, that will be executed on each issue. Returning true means the fix was successful, false that it wasn't:

pub trait Issue {

@QuiiBz QuiiBz added the enhancement New feature or request label Sep 21, 2023
@QuiiBz QuiiBz closed this as completed in #14 Nov 1, 2023
@QuiiBz
Copy link
Owner Author

QuiiBz commented Nov 1, 2023

Re-opening, only a single rule is auto-fixable right now.

@QuiiBz
Copy link
Owner Author

QuiiBz commented Nov 25, 2023

@QuiiBz QuiiBz closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant