Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types in dependencies rule #9

Merged
merged 2 commits into from Sep 22, 2023
Merged

feat: add types in dependencies rule #9

merged 2 commits into from Sep 22, 2023

Conversation

QuiiBz
Copy link
Owner

@QuiiBz QuiiBz commented Sep 22, 2023

Closes #8

Private packages shouldn't have @types/* in dependencies, since they don't need it at runtime. Move them to devDependencies.

@QuiiBz QuiiBz added the enhancement New feature or request label Sep 22, 2023
@QuiiBz QuiiBz merged commit 066a070 into main Sep 22, 2023
4 checks passed
@QuiiBz QuiiBz deleted the feat/types-in-deps branch September 26, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: rule to detect @types/* packages in dependencies instead of devDependencies
1 participant