You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The main issue here is setting maxDamage and maxCount.
Right now, maxDamage is always called after maxCount. The problem is, even if the argument is 0, it still sets maxCount to 1, so all items created with itemSettingsOf don't stack.
If they're swapped, they create an unexpected behavior with default values: setting damage but not setting stack size, tries to set stack size to 64 and throws an exception.
Perhaps all arguments should be null by default like most of them are instead.
The text was updated successfully, but these errors were encountered:
The main issue here is setting maxDamage and maxCount.
Right now, maxDamage is always called after maxCount. The problem is, even if the argument is 0, it still sets maxCount to 1, so all items created with itemSettingsOf don't stack.
If they're swapped, they create an unexpected behavior with default values: setting damage but not setting stack size, tries to set stack size to 64 and throws an exception.
Perhaps all arguments should be null by default like most of them are instead.
The text was updated successfully, but these errors were encountered: