Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemSettingsOf creates incorrect settings #57

Open
Cypher121 opened this issue Dec 7, 2022 · 0 comments
Open

itemSettingsOf creates incorrect settings #57

Cypher121 opened this issue Dec 7, 2022 · 0 comments

Comments

@Cypher121
Copy link
Contributor

The main issue here is setting maxDamage and maxCount.

Right now, maxDamage is always called after maxCount. The problem is, even if the argument is 0, it still sets maxCount to 1, so all items created with itemSettingsOf don't stack.

If they're swapped, they create an unexpected behavior with default values: setting damage but not setting stack size, tries to set stack size to 64 and throws an exception.

Perhaps all arguments should be null by default like most of them are instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant