New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long option names & update help message #235
Conversation
src/org/jetbrains/java/decompiler/main/extern/IFernflowerPreferences.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- Add a `@Type` for identifying how the given input string is interpreted - Add `@Documented` to the important annotations - Fix typos here and there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are also good for the intellij plugin. I didn't like having to guess types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tysm for doing this! The README needs to be updated, but that can be lower priority.
This also may allow for easier work on combination flags, like perhaps a
--no-removal
which would apply--no-remove-bridge --no-remove-synthetic --no-remove-getclass --no-remove-empty-try-catch --no-remove-imports
or something like that