Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long option names & update help message #235

Merged
merged 7 commits into from Mar 29, 2023

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Dec 28, 2022

This also may allow for easier work on combination flags, like perhaps a --no-removal which would apply --no-remove-bridge --no-remove-synthetic --no-remove-getclass --no-remove-empty-try-catch --no-remove-imports or something like that

Copy link
Contributor

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

- Add a `@Type` for identifying how the given input string is interpreted
- Add `@Documented` to the important annotations
- Fix typos here and there
Copy link
Contributor

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are also good for the intellij plugin. I didn't like having to guess types

@jaskarth jaskarth self-assigned this Feb 10, 2023
@jaskarth jaskarth added Priority: Medium Medium priority Subsystem: User-Facing Anything concerning user facing code labels Feb 10, 2023
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tysm for doing this! The README needs to be updated, but that can be lower priority.

@jaskarth jaskarth merged commit ef225b1 into Vineflower:develop/1.10.0 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Medium priority Subsystem: User-Facing Anything concerning user facing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants