Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a GET request with a body fails silently #4

Open
natenorberg opened this issue Aug 27, 2019 · 0 comments
Open

Sending a GET request with a body fails silently #4

natenorberg opened this issue Aug 27, 2019 · 0 comments

Comments

@natenorberg
Copy link
Contributor

Apparently, whatwg/fetch throws an error if you make a GET request that has a body defined. There's an issue for it (whatwg/fetch#551) but it doesn't seem like they're willing to change it.

Unfortunately, the error is swallowed with a try/catch, so it took me a while to figure out what was going on. The request never showed up in the network tab, but it would throw a timeout error eventually.

It would be nice if the error could be rethrown if it's something that prevents the fetch call from even happening. Otherwise, we should propagate the error back so it's not hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant