Allow per project access for anonymous and logged-in users #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it will be prudent to squash these commits before we do the final merge. |
|
The commit 0f183da is the one to test on staging... |
|
@cofiem - we did a review of the changes. They seem to work well. Lots of positive feedback. There were some design comments. I've written up the notes. There's a little bit of work to be done around naming and word choices. See https://github.com/QutBioacoustics/Ecoacoustics/blob/master/Design%20documents/Permissions%20Feedback.md |
|
Changes Unknown when pulling fefc5e1 on feature-allow-anon-2016 into * on develop*. |
Conflicts: db/structure.sql
create a permission for owner after a project is created added guest role, guest permissions, and removed :none access level updated Access methods throughout app added permission queries and updated method calls
removed ordering in permissions that overrided filter queries updated home page to show sample of available projects
Conflicts: spec/acceptance/scripts_spec.rb
Design feedback document: https://github.com/QutBioacoustics/Ecoacoustics/blob/master/Design%20documents/Permissions%20Feedback.md - Added 'ladder' permissions (bootstrap list-groups) to make permission levels clearer - Restricted user query to users role for permissions page - Added a recaptcha to registrations page - Made all columns button columns in individual permissions always buttons - Added extra columns in individual permissions to explain permissions - Reworded text on permissions page - Switched to a new project layout on projects index - Fixed wording on home page - Added a stub method (currently unused) to core.rb
Also tweaked UI a bit more
cofiem
force-pushed
the
feature-allow-anon-2016
branch
from
fefc5e1
to
7069de4
Compare
|
Commits squashed, and develop merged in. This branch is ready to be merged with develop. |
atruskie
changed the title
|
Woot! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
See also https://github.com/QutBioacoustics/baw-server/wiki/Permissions