Added analysis_job_id and audio_recording_id to results API #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also needed to add support for modifying the options that were passed into the rspec_api_documentation helper method `standard_request_options`
|
Tests pass locally. Travis error seems to be because of https://github.com/brigade/haml-lint/blob/master/CHANGELOG.md#0130 |
| # @return [void] | ||
| def standard_request_options(http_method, description, expected_status, opts = {}) | ||
| def standard_request_options(http_method, description, expected_status, opts = {}, &opts_mod) |
There was a problem hiding this comment.
I'm not so sure about this proc - a block might be better. I'll have a look at it.
There was a problem hiding this comment.
the proc is needed because AFAIK you can't pass a block through to another closure without an explicit name. Otherwise the implicit block of the closure would be referenced. example on line 37, has its own block. Using yield on 41 I think causes issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also needed to add support for modifying the options that were passed
into the rspec_api_documentation helper method
standard_request_optionsCloses #282