chore: Updated development environment #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed default paths in default.yml to isolate to environment (otherwise tests wipe out caches for development environments) - added a google maps key stub to prevent the script templater from erroring - changed seeds.rb so that whenever db:setup is run it force resets the details (for those users in particular we want them to always have a known state) - Updated readme.md to deal with the realities of guard and filesystem polling events - Added style guide link to documentation - changed the windows nfs config to map the nfs mount to the vagrant user - changed the vagrant VM memory default to 1.5GB of RAM (ran out of space while running dev server and running tests)
| if User.where(user_name: 'Admin').first.blank? | ||
| admin = User.new | ||
| else | ||
| admin = User.where(user_name: 'Admin').first |
There was a problem hiding this comment.
Why do the user attributes need to be reset every time the database is seeded?
There was a problem hiding this comment.
I changed this mainly to help me setup a database which I had copied off staging. My logic follows
- seed is only run at initial db:setup at the moment
- the password seed may not be the same, meaning logins won't work. Useful to reset these accounts
- changing the behavior makes db:seed useful for setting the state of the database to a desired state. Admin/harvester should always have the email and password from settings
I thought these changes were useful to keep. Main reason for this whole PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(otherwise tests wipe out caches for development environments)
erroring
details (for those users in particular we want them to always have a
known state)
polling events
user
space while running dev server and running tests)