[WIP] Analysis job items table #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - faulty! Working on permissions
Started adding routes and route specs. Rolled back sprockets dependency due to rails/sprockets#283
Routing was barely working. Lots of changes there. Also merged defunct analysis_controller into analysis_jobs_item controller.
Also fixed routing tests. Simplified routing quite a bit by not routing to non-standard system_* actions. Part way through implementation and fixing of controller and acceptance tests.
Just need to get it to work 😉
just need to get permissions to work and to re-enable fail in status transition
worked out the problem: "sites"."id" = "audio_recordings_analysis_jobs_items"."site_id" doesn't work, site_id is NULL. Need to pull site_id from audio_recordings table
yay! 😂 Failing test fails because filter query builder doesn't know to use the system_query to form the base of the filter conditions.
Added support for customising the base relation used to join table when doing a cross table condition in a filter.
- moved 'system' token to AnalysisJobsItem model - Created getter for analysis_job_id in AnalysisJobsItem model so that system token will be properly returned in API results - Added support for different filter settings for system results - Cleaned up controller. Refactored results_path and fixed a few related bugs - Updated analysis_jobs_items_results_spec tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
Fixes #192
Fixes #274