Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate filter values #309

Merged
merged 2 commits into from
Dec 4, 2016
Merged

validate filter values #309

merged 2 commits into from
Dec 4, 2016

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Dec 3, 2016

See #305

@coveralls
Copy link

coveralls commented Dec 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 85.132% when pulling 98112c4 on fix-validate-filter-values into 47f8fc2 on develop.

@atruskie
Copy link
Member

atruskie commented Dec 4, 2016

@cofiem this looks great - thanks!

Can you verify the associated documentation is still accurate? https://github.com/QutBioacoustics/baw-server/wiki/API:-Filtering
As far as I can tell it still is.

@cofiem
Copy link
Contributor Author

cofiem commented Dec 4, 2016

No worries. I added one more commit to make the class checks consistent.

Yes, the documentation is still correct. I updated it to add a line about the types of values expected.

@coveralls
Copy link

coveralls commented Dec 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 85.115% when pulling 07cebfa on fix-validate-filter-values into 47f8fc2 on develop.

@atruskie atruskie merged commit 336df7c into develop Dec 4, 2016
@atruskie atruskie deleted the fix-validate-filter-values branch June 4, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cofiem @coveralls @atruskie