Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Core.dll missing from PoeHelper #74

Open
HugKitten opened this issue Sep 26, 2019 · 2 comments
Open

System.Core.dll missing from PoeHelper #74

HugKitten opened this issue Sep 26, 2019 · 2 comments

Comments

@HugKitten
Copy link

HugKitten commented Sep 26, 2019

The PoeHelper folder is missing System.Core.dll which breaks projects that uses Linq. For instance this repository compiles fine on visual studio, but breaks when using the loader compiler. GetAllDllFilesFromRootDirectory does not include the assembly because it is missing from the PoeHelper folder and the plugin does not reference System.Core.dll because it is automatically referenced by the build system.

@Dragomitch
Copy link

Dragomitch commented Sep 29, 2019

Edit : Maybe a problem of referencing into the project of the randomFeatures to the dlls/libs of the project ?

@HugKitten
Copy link
Author

HugKitten commented Sep 30, 2019

The code for ExileAPI uses the references listed in the project's file. System.Core.dll is not included in this list. Instead it's automatically compiled with the project. The ExileAPI code that compiles the dll itself does not include System.Core.dll as an assembly. Apparently System.Core.dll is compiled into projects regardless of if it's included as a reference or not, and I was unable to add the reference to the plugin without an error through visual studios. I think compiler code for ExileAPI should work the way the Visual Studios IDE compiles the plugin. Currently standing a visual studios project for a plugin may compile just fine, but not work when you use CompilePlugins.bat. I see this as a problem and I believe adding System.Core.dll into the ExileAPI folder would solve this. (All dlls in the ExileAPI folder are compiled with the plugins with ExileAPI's code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants