New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recycling POI block #648
Merged
Merged
Recycling POI block #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Ray
reviewed
May 22, 2020
bbecquet
force-pushed
the
poi-block-recycling
branch
from
May 26, 2020 15:05
9649f77
to
1344ef3
Compare
bbecquet
force-pushed
the
poi-block-recycling
branch
from
June 1, 2020 09:18
1344ef3
to
4d3a5d3
Compare
G-Ray
reviewed
Jun 1, 2020
amatissart
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a "Recycling" POI block, to display details about recycling containers.
Note
This PR is quite big for such content as I used it as an excuse to introduce things that I think were currently missing and can ease development for all parts of the app in the future:
<Flex>
component. It's very basic for now, to be completed when needed and/or replaced by a similar component from the Qwant Design System if we find a way to use it one day… The goal is to promote the use of theflex
layout in a standard way, instead of floats or absolute positionings that are still used in many parts of the app with a lot of unnecessary CSS and many inconsistencies.<Text>
component, to standardize the typographic classes beyond just CSS and do common patterns in a consistent way (like displaying an icon before the text). As for<Flex>
, it's meant to be re-used anywhere possible, adapted to our needs and replaced by a Design System component when the time is right.<Meter>
component as a shared one, so it can be re-used easily in other parts if needed. BTW, it's a choice not to use the nativemeter
HTML element, as it's a real hell to style properly and would introduce broken designs on older browsers.It's now possible to do:
Screenshots