fix: Fail on first pg error, to avoid infinite iteration #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
force-pushed
the
fix-pg-error
branch
from
534981b
to
8104161
Compare
jbgriesner
approved these changes
Sep 16, 2019
remi-dupre
pushed a commit
that referenced
this pull request
Sep 1, 2022
fix: Fail on first pg error, to avoid infinite iteration
remi-dupre
pushed a commit
that referenced
this pull request
Sep 2, 2022
fix: Fail on first pg error, to avoid infinite iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors from the postgres database were not handled properly. A broken connection could lead to an infinite loop with warning messages:
The new implementation uses
itertools::process_resultsto exit early if such an error occurs.