Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PyPI package missing required dependencies #55

Closed
tocic opened this issue Mar 26, 2021 · 1 comment · Fixed by #56
Closed

[BUG] PyPI package missing required dependencies #55

tocic opened this issue Mar 26, 2021 · 1 comment · Fixed by #56
Labels
bug Something isn't working

Comments

@tocic
Copy link

tocic commented Mar 26, 2021

Describe the bug
I can't install all the required dependencies using pip install contextualSpellCheck. It seems like PyPI package doesn't contain the fix.

To Reproduce

python -m venv venv
source venv/bin/activate
pip install contextualSpellCheck
python -c 'import contextualSpellCheck'

ModuleNotFoundError: No module named 'torch'

Expected behavior
torch and other deps autoinstallation.

Version (please complete the following information):
latest 0.4.0 contextualSpellCheck from PyPI.

Additional information
see #17 and #18.

@tocic tocic added the bug Something isn't working label Mar 26, 2021
@R1j1t
Copy link
Owner

R1j1t commented Mar 27, 2021

I remember removing the pytorch package from deps because I saw that contextualSpellCheck another dependency transformers already had it in its setup.

See the below line in transformers:
https://github.com/huggingface/transformers/blob/b0595d33c1b1abb75fc42a54553c724154cf6cd0/setup.py#L131

I am not sure why transformers library did not trigger the pytorch download. No worries, I will add it again as part of the dependency in setup.py. Thank you for pointing out this issue! Feel free to create a PR to fix this issue. By tomorrow I will update the dependencies and release the fix to PyPI. I will also try to investigate why transformers did not trigger pytorch download.

@R1j1t R1j1t mentioned this issue Mar 28, 2021
2 tasks
@R1j1t R1j1t closed this as completed in #56 Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants