Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MAD mods on leaving server #670

Open
Alystrasz opened this issue Feb 16, 2024 · 5 comments
Open

Disable MAD mods on leaving server #670

Alystrasz opened this issue Feb 16, 2024 · 5 comments

Comments

@Alystrasz
Copy link
Contributor

As we don't want MAD mods to conflict with other mods, mods that have been downloaded to join a server should be disabled after leaving said server.

@GeckoEidechse GeckoEidechse changed the title Disable MAD mods Disable MAD mods on server leave Feb 16, 2024
@GeckoEidechse GeckoEidechse changed the title Disable MAD mods on server leave Disable MAD mods on leaving server Feb 16, 2024
@ASpoonPlaysGames
Copy link
Contributor

In a similar vein as this: R2Northstar/NorthstarMods#263

Any mods that get enabled/disabled specifically to join a server should get reverted back to the state they were in after leaving the server.

Some pointers for implementation:

  • Can't just store this in UI vm, since uiscript_reset might get ran when enabling/disabling mods, so the data would be lost.
  • Launcher implementation is probably best, perhaps saving enabledmods state via a script call and then rolling back to the saved state later via a second script call

@RoyalBlue1
Copy link
Contributor

For implementation can't we enable/disable the mods according to the server without writing it to enabledmods and then on every server leave we load enabledmods again to reset to the previous state

@ASpoonPlaysGames
Copy link
Contributor

For implementation can't we enable/disable the mods according to the server without writing it to enabledmods and then on every server leave we load enabledmods again to reset to the previous state

Yeah that would work, could have "temporarily" enabled/disabled mods by doing that. However reloading mods on every server leave isn't great, we should check to make sure that there are currently some "temporarily" enabled/disabled mods first

@Alystrasz
Copy link
Contributor Author

For implementation can't we enable/disable the mods according to the server without writing it to enabledmods and then on every server leave we load enabledmods again to reset to the previous state

Can we really avoid using enabledmods here?
Maybe a server leave callback wouldn't be triggered if players rage quit the game during a match 😄

@Alystrasz
Copy link
Contributor Author

Launcher-side, is there any particular method (hook?) that is triggered on leaving a game?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants