Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the schemas in a human-readable form #20

Open
blootsvoets opened this issue Apr 5, 2017 · 5 comments
Open

Publish the schemas in a human-readable form #20

blootsvoets opened this issue Apr 5, 2017 · 5 comments

Comments

@blootsvoets
Copy link
Member

We could do this in a GitHub.io page just posting the javadoc. There is a avrodoc documentation generator but that doesn't support references to other types (Such as restapi/app/application.avsc refers to restapi/app/server_status.avsc.

@fnobilia
Copy link
Member

fnobilia commented Apr 5, 2017

Does it supports only embedded schemas?

@blootsvoets
Copy link
Member Author

Yes: ept/avrodoc#19. And its unmaintained. I haven't found an alternative so far though...

@fnobilia
Copy link
Member

fnobilia commented Apr 5, 2017

At present, for the Rest API is almost impossible to avoid embedded schemas, we will end up with a single .avsc file containing almost all schemas. I don't think it can be easily maintained.

It is in my plan to structure the Rest API project to improve the modularisation and to simplify future integrations. I may try to restructure the Dataset schema to mitigate its dependencies. If this is a low priority task and we can wait a little bit, I will get back to you with a more precise solution.

I see your point of publishing schemas in a human-readable form. I totally agree. However, are we sure we want to rely on a project that is unmaintained since 4 years? It is quite risky.

@blootsvoets
Copy link
Member Author

No on the contrary, I think we shouldn't use Avrodoc. But we should have some form of documentation. Perhaps the route avsc -> JSON schema -> doc would also provide proper documentation, although we might loose some information in the conversion.

@blootsvoets
Copy link
Member Author

blootsvoets commented Apr 5, 2017

BTW: by putting all files in a single protocol file, and putting them in an order where each type is defined before it is referenced, avrodoc seems to work fine. For now, that's quite some manual work though.
screen shot 2017-04-05 at 16 05 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants