fix(site-templates): fixes for HTML validation

Use blank image data url instead of src="". Change #map-export-toggle button to be psuedo-disabled. Pull list out of p-tag in the help section. Remove type attribute from image download link. Closes #8777
RAMP-PCAR · Mar 26, 2015 · ce4f7a9 · ce4f7a9
1 parent 976a014
commit ce4f7a9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/site/includes/help.hbs b/site/includes/help.hbs
@@ -110,12 +110,12 @@
             </figure>
             <p>
                 {{t "help.s6.p2"}}
-                <ul>
-                    <li>{{t "help.s6.ul2.li1"}}</li>
-                    <li>{{t "help.s6.ul2.li2"}}</li>
-                    <li>{{t "help.s6.ul2.li3"}}</li>
-                </ul>
             </p>
+            <ul>
+                <li>{{t "help.s6.ul2.li1"}}</li>
+                <li>{{t "help.s6.ul2.li2"}}</li>
+                <li>{{t "help.s6.ul2.li3"}}</li>
+            </ul>
             <h4>{{t "help.s6.h3"}}</h4>
             <p>{{t "help.s6.p3"}}</p>
             <h4>{{t "help.s6.h4"}}</h4>

diff --git a/site/pages/ramp.hbs b/site/pages/ramp.hbs
@@ -95,7 +95,7 @@
                 </button>
             </li>
             <li class="map-toolbar-item">
-                <a class="btn btn-xs map-toolbar-item-button button-none wb-lbx lbx-modal" href="#map-export-modal" aria-controls="map-export-modal" id="map-export-toggle" disabled>
+                <a class="btn btn-xs map-toolbar-item-button button-none wb-lbx lbx-modal disabled" href="#map-export-modal" aria-disabled="true" aria-controls="map-export-modal" id="map-export-toggle">
                     <i class="fa fa-download"></i><span class="on-right">{{t "gui.actions.mapExport"}}</span>
                 </a>
 
@@ -115,7 +115,7 @@
                                     <span class="wb-inv">{{t "mapExport.loading"}}</span>
                                 </div>
                                 <div class="map-export-image">
-                                    <img src="" alt="">
+                                    <img src="data:image/gif;base64,R0lGODlhAQABAAAAACwAAAAAAQABAAA=" alt="">
                                 </div>
                             </div>
                             <div class="map-export-controls">
@@ -132,7 +132,7 @@
                                         <!--<button class="btn btn-primary" type="button">
                                 <i class="fa fa-download"></i><span class="on-right">{{t "mapExport.downloadImage"}}</span>
                             </button>-->
-                                        <a class="btn btn-primary" type="button" href="" target="_blank" download="">
+                                        <a class="btn btn-primary" href="" target="_blank" download="">
                                             <i class="fa fa-download"></i><span class="on-right">{{t "mapExport.downloadImage"}}</span>
                                         </a>
                                         <!--<button class="btn btn-primary" type="button">

diff --git a/src/js/RAMP/Modules/imageExport.js b/src/js/RAMP/Modules/imageExport.js
@@ -127,7 +127,8 @@ define([
                     downloadButton = $(".map-export-controls .download-buttons > .btn");
 
                     mapExportToggle
-                        .attr("disabled", false)
+                        .removeClass('disabled')
+                        .attr('aria-disabled', false)
                         .on('click', generateExportImage);
                 }
             };