Skip to content

Commit

Permalink
fix(ui): move noDataTimeLine creation to later stage
Browse files Browse the repository at this point in the history
move noDataTimeLine creation to later stage to accomidate IE9 not
generate tabs fast enough.

Closes #9608
  • Loading branch information
Jack authored and Jack committed May 12, 2015
1 parent dcba250 commit fcded2e
Showing 1 changed file with 20 additions and 7 deletions.
27 changes: 20 additions & 7 deletions src/js/RAMP/Modules/gui.js
Original file line number Diff line number Diff line change
Expand Up @@ -968,13 +968,6 @@ define([
}
];

// timeline that hides Data tab
noDataTimeLine
.fromTo(panelDiv.find(".wb-tabs > ul li:first"), transitionDuration, { width: "50%" }, { width: "100%", className: "+=h5", ease: "easeOutCirc" }, 0)
.to(panelDiv.find(".wb-tabs > ul li:first"), transitionDuration, { lineHeight: '20px' }, 0)
.fromTo(panelDiv.find(".wb-tabs > ul li:last"), transitionDuration, { width: "50%" }, { width: "0%", display: "none", ease: "easeOutCirc" }, 0)
;

/**
* Fires an event when the layout of the page changes.
*
Expand Down Expand Up @@ -1146,6 +1139,22 @@ define([
}
}

/**
* Setup noDataTimeLine for data tab animation
*
* @method setupNoDataTimeLine
* @private
*/
function setupNoDataTimeLine() {

// timeline that hides Data tab
noDataTimeLine
.fromTo(panelDiv.find(".wb-tabs > ul li:first"), transitionDuration, { width: "50%" }, { width: "100%", className: "+=h5", ease: "easeOutCirc" }, 0)
.to(panelDiv.find(".wb-tabs > ul li:first"), transitionDuration, { lineHeight: '20px' }, 0)
.fromTo(panelDiv.find(".wb-tabs > ul li:last"), transitionDuration, { width: "50%" }, { width: "0%", display: "none", ease: "easeOutCirc" }, 0)
;
}

return {
/**
* Initializes layout controller.
Expand Down Expand Up @@ -1200,6 +1209,10 @@ define([
}

adjustHeight();

// setup noDataTimeLine here to allow IE9 to have enough time to
// create the tab
setupNoDataTimeLine();
},

/**
Expand Down

0 comments on commit fcded2e

Please sign in to comment.