Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a meeting participant leaves the models from the host should be closed #2

Open
tomgoddard opened this issue Oct 10, 2023 · 1 comment

Comments

@tomgoddard
Copy link
Contributor

In LookSee version 8 if a participant joins a meeting and receives a model, then leaves the meeting, they still have the model shown, and if they rejoin the meeting that model gets transferred to the other participants and copy that was still in the meeting is transferred to the new joiner, so everybody now has two copies of the model. It would probably be better if leaving the meeting closes models that were transferred from others in the meeting so this duplication does not occur.

@tomgoddard
Copy link
Contributor Author

To have a rejoin not duplicate models the model leaver should have all models closed including the ones they opened when they were previously in the meeting.

If the person is not going to rejoin the meeting then leaving all models open might be nicer behavior.

Another approach to avoid duplicates is that all your models are closed when you join a meeting, and you get all the models from the host of the meeting.

Another solution would be that when joining the meeting you keep all models not already in the meeting. This is tricky because we don't currently create or share hashes to decide when two models are the same. The may have the same name (e.g. "scene") and yet be different models.

It is not clear what the most commonly useful behavior is. I think if you open a model before joining the meeting, maybe you did not intend to share it, so closing and getting any existing models from the meeting might be the best behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant