Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose viewModel lookup ignores fragment in FragmentManager different than supportFragmentManager #526

Closed
jakoss opened this issue Aug 16, 2022 · 3 comments · Fixed by #527

Comments

@jakoss
Copy link
Contributor

jakoss commented Aug 16, 2022

I have the case of navigation based on a FragmentManager of a parent fragment via the childFragmentManager property.

Unfortunately the current implementation of currentFragmentOrNull checks only the activity.supportFragmentManager stack thus ignoring my fragments. Injecting of ViewModel works, but fragment arguments are not passed to the SavedStateHandle

@jakoss
Copy link
Contributor Author

jakoss commented Aug 16, 2022

Please review my Pull Request and merge it if you think it's good enough :). It's basically the same thing i did in the maverics-compose integration for fragment lookup

@kodiakhq kodiakhq bot closed this as completed in #527 Aug 23, 2022
@jakoss
Copy link
Contributor Author

jakoss commented Aug 24, 2022

@RBusarow Are you planning on some release in a near future?

@RBusarow
Copy link
Owner

Doing this now. I'd have done it last night, but the Gradle Plugin Portal outage delayed things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants