Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider "hashing tx" stage #53

Closed
RCasatta opened this issue Jun 6, 2022 · 2 comments
Closed

Consider "hashing tx" stage #53

RCasatta opened this issue Jun 6, 2022 · 2 comments
Labels
breaking binary format

Comments

@RCasatta
Copy link
Owner

RCasatta commented Jun 6, 2022

As shown in perf report here rust-bitcoin/bitcoin_hashes#160

in the memory case a lot of time is spent in hashing bitcoin tx, consider having a pipeline stage creating the hash of tx and storing it in the BlockExtra so that following stages could simply use the cached value
@dpc
Copy link
Contributor

dpc commented Jun 6, 2022

Smart!

@RCasatta RCasatta mentioned this issue Jun 7, 2022
Closed
@RCasatta RCasatta mentioned this issue Jun 8, 2022
Merged
@RCasatta
Copy link
Owner Author

Done in #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking binary format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpc @RCasatta