Fixes to Dockerfile #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The optix SDK needs an nvidia dev account so probably not, the headers can be downloaded from a link just fine but im pretty sure the sdk installer does other things too |
guide/src/guide/getting_started.md
Outdated
| @@ -90,7 +92,7 @@ Now we can finally start writing an actual GPU kernel. | |||
| <details> | |||
| <summary>Expand this section if you are not familiar with how GPU-side CUDA works</summary> | |||
|
|
|||
| Firstly, we must explain a couple of things about GPU kernels, specifically, how they are executed. GPU Kernels (functions) are the entry point for executing anything on the GPU, they are the functions which will be executed from the CPU. GPU kernels do not return anything, they write their data to buffers passed into them. | |||
| Firstly, we must explain a couple of things about GPU kernels, specifically, how they are executed. GPU Kernels (functions) are the entry oint for executing anything on the GPU, they are the functions which will be executed from the CPU. GPU kernels do not return anything, they write their data to buffers passed into them. | |||
There was a problem hiding this comment.
whoops must have deleted that somehow. Thanks for pointing it out. Should be fixed now
for some reason using `LD_LIBRARY_PATH` was causing problems with cuda finding the device. Reverting to ldconfig fixes the issue add more docker info including debugging notes fix missing `p` in entrypoint
I did notice it required a dev account. I wasn't sure if the install script they provide could just be bundled with this and be used to build in optix. That's cool though I think this Dockerfile is complete for now then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the minor PRs in succession. I realized there were some minor issues with the Dockerfile that are now fixed and running the add example successfully seems to confirm it is working properly.
Details: The primary issue was that building succeeded, but running failed to create a context. This was somehow related to
ldnot finding the shared objects despite being inLD_LIBRARY_PATH. I reverted toldconfigand this fixed the issue.Starting this PR as a draft to hear opinions on whether the Dockerfile should optionally include optix with a build argument. I have not investigated this much but I can look into it.