Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed feature to auto delete redundant strings #106

Open
Zenlua opened this issue May 10, 2024 · 5 comments
Open

Proposed feature to auto delete redundant strings #106

Zenlua opened this issue May 10, 2024 · 5 comments

Comments

@Zenlua
Copy link

Zenlua commented May 10, 2024

Can you add feature flags?

This feature will be useful for someone adding a language pack, and some extra strings will give an error, but if there are too many extra strings, it will take a long time to delete.

It is possible to use loops to automatically delete, but it is quite cumbersome

@REAndroid
Copy link
Owner

What is the logic to filter "extra strings" that works for all apks ?

@Zenlua
Copy link
Author

Zenlua commented May 26, 2024

If the added strings file has a key that does not exist in the original strings, the extra string will be auto deleted, In apktool will add ids, and a warning appears that string does not exist, but this is redundant.

@REAndroid
Copy link
Owner

Try new (beta) update
To activate advanced features clone and build with:
./gradlew betaJar

@Zenlua
Copy link
Author

Zenlua commented Jun 4, 2024

When I add extra text to the string it still shows an error.

ERROR: Undefined entry name: <string name="testkk"/>Wed</string>

@Zenlua
Copy link
Author

Zenlua commented Jun 4, 2024

You can rely on public.xml to filter out redundant text. Any text that has not been added in public.xml will be auto deleted. This can apply to all other items: array, dimen, bool, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants