Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several suggestions #6

Open
JeffMill opened this issue Dec 14, 2022 · 0 comments
Open

Several suggestions #6

JeffMill opened this issue Dec 14, 2022 · 0 comments

Comments

@JeffMill
Copy link

  1. message("Bootstrapping vcpkg in ${VCPKG_ROOT}") should read message(STATUS "Bootstrapping vcpkg in ${VCPKG_ROOT}")
  2. execute_process(COMMAND ${VCPKG_BOOTSTRAP} WORKING_DIRECTORY ${VCPKG_ROOT}) could include -disableMetrics , i.e. execute_process(COMMAND ${VCPKG_BOOTSTRAP} -disableMetrics WORKING_DIRECTORY ${VCPKG_ROOT}). Perhaps make it a configuration parameter?
  3. (nit) You should set your editor to trim trailing whitespace at end of line.

Thanks! Great product.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeffMill