Reservations fail with error "Content is not allowed in prolog"

[hinchliff]

New reservations in release 5.3.0 can fail with the following error message:

Last lease update: all units failed priming: Exception during join for unit: DC97B1F6 Content is not allowed in prolog

It appears that some of the changes from mvn formatter:format have caused errors in XML files, specifically when the XML files have DOCTYPE statements, as in tools/cmdline/build.xml.

Formatting changes to these files will need to be reverted.

[ibaldin]

Probably also want to somehow limit the execution of that plugin to avoid it running on XML files again? Is taht possible?

[hinchliff]

I think this command is correctly reverting all XML files with DOCTYPE in them
find . -type f -name '*.xml' -exec grep -l DOCTYPE {} + | xargs git checkout 0ff070ee~1 --

Still investigating if this is the best way.

[ibaldin]

Aren't all XML files required to have a DOCTYPE?

[hinchliff]

I'm not sure about the requirement, but most of them seem to not have one.

[ibaldin]

Huh. So we think this formatting issue is only for XML files with DOCTYPE explicitly declared?

[ibaldin]

Should we be on the safe side and revert all XML files?

[ibaldin]

Do we know if it touched RDF files?

[hinchliff]

Every other XML file that I have looked at seems OK. And it doesn't look like it touched RDF files.

The changes the plugin made to CSS file are a little off, so I think I will revert those too.