-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion on user-defined functions doesn't work. #27
Comments
Ya, it is supported in v0.2.4. |
Ai, there are actually a few bugs in v0.2.4. Please install the current master and try again. |
So glad to see that this feature will be improved soon. Awesome stuff! 👍 |
Actually, I just picked up the development today, langauageserver has not been updated for a while. |
I see. I think this project definitely brings much value to many members of the R community. It certainly does to me. |
Now that 0.2.5 is released, is this supposed to be fixed? |
It has not yet submitted to CRAN because CRAN was off. You need to install it via GitHub for now. |
Okay. I will wait until it's on CRAN then. |
V0.2.5 is out |
Doesn't seem working for me -- still unable to see a user-defined function appear in the completion list. |
I see. But why this limitation (the server only caches user functions when a file is opened or saved)? Other language servers I have worked on don't require this. Is it possible/does it make sense to make it in-memory as well? |
It is partly because R is unfortunately too slow. And a more economical reason is to save cpu power. Caching functions on the fly requires a lot of cpu power (related to R being slow). It is particularly important for laptop users. With that said, it is totally possible to make a setting to allow online caching. I am not a big fan of it and I would still recommend users turning it off, even if it exists, to save battery life. |
It would be expensive at the moment to cache workspace symbols on every key stroke. I'm wondering if it makes sense and if it's possible to cache every N seconds, something like cache interval option? |
1e1c74d should fix this. |
While completion on built-in functions like paste seems to work, completion on user-defined functions doesn't seem so.
For example, if I define a function like
addcustom
, and later I enter 'addcu
' expectingaddcustom
to be in the completion candidate list, it's not.The text was updated successfully, but these errors were encountered: