Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if symbol on rhs of assignment in definition #341

Closed
renkun-ken opened this issue Sep 22, 2020 · 0 comments · Fixed by #342
Closed

Check if symbol on rhs of assignment in definition #341

renkun-ken opened this issue Sep 22, 2020 · 0 comments · Fixed by #342

Comments

@renkun-ken
Copy link
Member

Consider the following code:

test <- 1
test <- test + 1

The definition should be following:

  1. test in line1: line 1
  2. test in line2 before <-: line 2
  3. test in line2 after <-: line 1

The current implementation of definition violates 3 as it will ignore whether the token is on the right side of the assignment expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checking symbol on rhs of assignment expression renkun-ken/languageserver
1 participant
@renkun-ken