Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal {styler} version requirement #457

Closed
lorenzwalthert opened this issue Jul 18, 2021 · 2 comments · Fixed by #458
Closed

Minimal {styler} version requirement #457

lorenzwalthert opened this issue Jul 18, 2021 · 2 comments · Fixed by #458

Comments

@lorenzwalthert
Copy link
Contributor

lorenzwalthert commented Jul 18, 2021 •
edited

{styler} won't ever bring up interactive prompt to create a cache (as requested by {R.cache}) as of version 1.5.1. For this reason, the corresponding README explanation becomes obsolete if you add a minimal version requirement on {styler} (1.5.1), which I suggest to do.
Also see r-lib/styler#819.
@renkun-ken
Copy link
Member

Looks like the new R.cache will by default uses a global cache root path for the user (~/.cache/R/R.cache). Then there seems to be no need to mention the cache issue in README at all.

@renkun-ken renkun-ken mentioned this issue Jul 19, 2021
Merged
@lorenzwalthert
Copy link
Contributor Author

The difference is that {R.cache} uses a standard location that does not require user permission according to CRAN policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require styler >= 1.5.1 renkun-ken/languageserver
2 participants
@renkun-ken @lorenzwalthert