Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for functions assigned with = differs from functions assigned with <- #466

Closed
krassowski opened this issue Aug 10, 2021 · 4 comments · Fixed by #467
Closed

Documentation for functions assigned with = differs from functions assigned with <- #466

krassowski opened this issue Aug 10, 2021 · 4 comments · Fixed by #467
Labels
bug

Comments

@krassowski
Copy link
Contributor

It seems that definitions for functions are not extracted properly when those are assigned with eq. Is this intended? This has an annoying effect for example when hovering over functions with signatures spread to multiple lines:

hover-func-r-eq
@renkun-ken
Copy link
Member

I could reproduce this. Completion and signature treats sum_eq as a function, but hover does not. Let me take a closer look at this.

@renkun-ken renkun-ken added the bug label Aug 10, 2021
@renkun-ken renkun-ken mentioned this issue Aug 11, 2021
Merged
@renkun-ken
Copy link
Member

Could you install the PR and check if it works for you?

remotes::install_github("REditorSupport/languageserver#467")

@krassowski
Copy link
Contributor Author

This works great, thank you - that was super quick!

@randy3k
Copy link
Member

randy3k commented Aug 11, 2021

This works great, thank you - that was super quick!

I agree. @renkun-ken is super responsive in bug fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hover on function defined with EQ_ASSIGN renkun-ken/languageserver
3 participants
@randy3k @renkun-ken @krassowski