Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Windows #7

Closed
randy3k opened this issue Jan 28, 2018 · 10 comments
Closed

Not working on Windows #7

randy3k opened this issue Jan 28, 2018 · 10 comments

Comments

@randy3k
Copy link
Member

randy3k commented Jan 28, 2018

Windows does not read from STDIN non-blocking-ly. We might need to use PEEKNAMEDPIPE to check that STDIN is ready.

@rwatts3
Copy link

rwatts3 commented Jan 30, 2018

I see that this is closed , however I still can't install via windows. Is there an alternative solution proposed that wasn't documented here ?

@randy3k
Copy link
Member Author

randy3k commented Jan 30, 2018

It should be working on Windows. But you need to

  1. have Rtools installed
  2. expose the path to R.exe via the PATH environmental variable.

@rwatts3
Copy link

rwatts3 commented Jan 30, 2018

ok i'll install rtools,
and try to re-install

@rwatts3
Copy link

rwatts3 commented Jan 30, 2018

Completed step 1.
A little confused about step 2, however I selected the PATH option in the installation wizard, wondering if this is the same as step 2.

Either way the languageserver still does not work properly after installation.

@randy3k
Copy link
Member Author

randy3k commented Jan 30, 2018

It seems that you have the server installed properly, but the language client that you are using does not work properly on Windows. To be honest, I have only tested the server with Sublime Text on Windows. The VScode and Atom clients may not work...

@randy3k
Copy link
Member Author

randy3k commented Jan 31, 2018

Let me reopen it, I can confirm that that it does not play well on Atom. Maybe I should also implement a tcp socket entry point.

@randy3k randy3k reopened this Jan 31, 2018
@rwatts3
Copy link

rwatts3 commented Jan 31, 2018

thank you

@randy3k
Copy link
Member Author

randy3k commented Feb 1, 2018

13c3db5 has implemented the socket connection. I have tested on both Sublime Text and Atom.

@Ikuyadeu vscode-r-lsp should use the tcp connection on Windows as stdio doesn't work on Windows. atom-ide-r has also switched to tcp connection.

@randy3k randy3k closed this as completed Feb 1, 2018
@Ikuyadeu
Copy link
Member

Ikuyadeu commented Feb 1, 2018

@randy3k Thank you for information!
I'll fix it on this weekend.But I don't have Windows.
Could you use the vscode-r-lsp after I published the new version.

@randy3k
Copy link
Member Author

randy3k commented Feb 1, 2018

I guess you just need to test the TCP connection on your mac/linux. Windows support should be spontaneous if the setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants