-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Pull Request Test Coverage Report for Build 398
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hai! I have one small request, but besides that, I'd prefer to change the watcher and patchwork class renaming. The watcher class has a comment about how it needs to be properly renamed or refactored, so only fixing the capitalization isn't very useful. Similarly, the patchwork classes should get similar names to their parent, to make it reflect that they are specific interfaces to the project, and the name doesn't need to include "skt" either.
I'd either drop those three patches from the pull, or come up with appropriate names which don't need to be changed next time. What do you think?
sktm/__init__.py
Outdated
@@ -21,7 +21,6 @@ | |||
import enum | |||
|
|||
import sktm.db | |||
import sktm.jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the imports in alphabetical order and remove the jenkins import below instead?
@veruu Thanks review. I do not come up with the name too. Do you have any suggestion for them. If not, I could probably drop them. What do you think? |
For the watcher, I'd keep that one untouched for now. As you might have noticed from the other pulls we want to split job queuing and checking so in the end, the watcher may be simplified or split appropriately as well. For the Patchwork classes, what would you think about |
4a59c5b
to
16be1a2
Compare
@veruu I drop the watcher's patch. The class names is good too, I fixed it. You can review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hai, looks good!
I make PR to make minor fixes