Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Dont enqueue baseline if it was already tested #146

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Dont enqueue baseline if it was already tested #146

merged 3 commits into from
Oct 29, 2018

Conversation

agustinhenze
Copy link
Contributor

No description provided.

@agustinhenze agustinhenze force-pushed the dont-enqueue-baseline-if-its-already-tested branch from 4bc892f to 0ca3a4e Compare October 29, 2018 14:47
@coveralls
Copy link

coveralls commented Oct 29, 2018 •
edited

Pull Request Test Coverage Report for Build 475

  • 18 of 20 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 38.807%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sktm/executable.py 0 2 0.0%
Totals Coverage Status
Change from base Build 471: 1.0%
Covered Lines: 482
Relevant Lines: 1125
💛 - Coveralls

major
major approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It would be nice to have an option to provide some kind of argument like --force if we really want sktm to run another test on the same baseline.

@major major merged commit 30305f4 into CKI-project:master Oct 29, 2018
@major major self-assigned this Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@major major major approved these changes

@spbnick spbnick Awaiting requested review from spbnick

Assignees

@major major

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agustinhenze @coveralls @major