add package.json props for umd vs es2015 vs es6 versions #22
Comments
if you or @mwcz can solve the current hell of knowing what to babel compile or not compile to get this error to go away then you'd be my hero - It's a precursor to the idea above. We'd need to pick a build routine that would allow for referenced repos so that it could be reviewed in storybook / the demo sites / etc; or, having a routine that rewrites the storybook / demo files to match the routine in question. |
It's probably something to do with the custom-elements-es5-adapter.js. If you're using ES6 files and have that file loaded, you'll get that error. Maybe take a look at https://stackoverflow.com/questions/43520535/class-constructor-polymerelement-cannot-be-invoked-without-new |
Thanks @btopro, this is awesome stuff. I remember seeing part of that talk and thinking it would come in handy some day. I'm totally onboard with this change. @btopro, any ideas on how we could add tests for this change? Perhaps some tiny webpack/etc projects that do nothing but npm install a RHElement, import it, and build? |
that sounds like a good enough |
Added main and module in #32 but with different prefixes:
|
If done correctly (we're way out of my element here admittedly) we could support all 3 forms of build routines via webpack / other bundles in the package.json. main currently points to index.js which doesn't exist. The talk / reference doc below discusses this idea --
https://youtu.be/Ucq9F-7Xp8I?t=28m51s
https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview#
basic idea would be to have something like
in the
package.json
. Could also help in resolving issues of umd vs non umd buildsThe text was updated successfully, but these errors were encountered: