Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆕 add workspace configuration #1

Merged
merged 2 commits into from Dec 19, 2022

Conversation

garasubo
Copy link
Collaborator

Add Cargo Workspace definition under src directory

This will help cargo commands to recognize these packages under this directories and improve developer exeperience.

@fukai-t
Copy link
Contributor

fukai-t commented Dec 13, 2022

Unfortunately, the build test with your PR have failed. Could you check the result of the test and try to fix it?
https://github.com/RIKEN-RCCS/MilvusVisor/actions/runs/3676166193/jobs/6231681560

@PG-MANA PG-MANA self-requested a review December 13, 2022 08:17
@PG-MANA
Copy link
Collaborator

PG-MANA commented Dec 13, 2022

You should rewrite .github/workflows/rust.yml
I think it is OK only to conbine two process: "Build Bootloader" and "Build Kernel" to "Build Hypervisor".

@garasubo
Copy link
Collaborator Author

Updated .github/workflows/rust.yml. Could you approve running workflows?

@PG-MANA
Copy link
Collaborator

PG-MANA commented Dec 19, 2022

LGTM, I will modify .github/workflows/rust.yml a little after merging.

@PG-MANA PG-MANA merged commit 7380218 into RIKEN-RCCS:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants