Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/pkg_semtech-loramac insufficient memory for arduino-mega2560 #12071

Closed
jcarrano opened this issue Aug 23, 2019 · 4 comments · Fixed by #12073
Closed

tests/pkg_semtech-loramac insufficient memory for arduino-mega2560 #12071

jcarrano opened this issue Aug 23, 2019 · 4 comments · Fixed by #12073

Comments

@jcarrano
Copy link
Contributor

Description

tests/pkg_semtech-loramac is failing to link for "arduino-mega2560" due to insufficient memory. The weird thing is that it was failing before but now the CI decided it wants to link that application, causing unrelated PRs to fail.

Expected results

The board is skipped for that test.

Actual results

The CI tries to link tests/pkg_semtech-loramac for arduino-mega2560 and fails.

See: https://ci.riot-os.org/RIOT-OS/RIOT/10635/1a2a239ebfd4b048621dec1d04d22d35526b5e99/output.html#error0

@aabadie
Copy link
Contributor

aabadie commented Aug 23, 2019

Which unrelated PR ? #10635 ? e.g. yours ?
The pkg_semtech-loramac application is using the shell and just fits on arduino-mega2560 (see the discussion in #11917 for example).
So this is not a CI issue as you suggest (other PRs just build fine) but certainly an issue with your PR. Indeed, it modifies the shell so it probably increase the code size. Have you checked that before opening this issue ?

@aabadie
Copy link
Contributor

aabadie commented Aug 23, 2019

I spoke too fast, I can reproduce the issue on master locally.

Git bisect points to this commit 41e440a from pr #11880. If we want to avoid problems with this board and this application, I propose to disable the semtech_loramac_rx module, this will save a lot of RAM/ROM and the package will still be built for this platform.

It would be great to know what caused the CI to start linking this application for this board.

@jcarrano
Copy link
Contributor Author

It would be great to know what caused the CI to start linking this application for this board.

That's precisely why I raised this issue. The failure itself is not a big deal, just disable the tests. What concerns me is the CI's behaviour.

@aabadie
Copy link
Contributor

aabadie commented Aug 26, 2019

The failure itself is not a big deal, just disable the tests

In case you missed it, #12073 does the job nicely, without having to disable the test for this board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants