Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: remove duplicate CoAP code #13330

Open
1 of 3 tasks
bergzand opened this issue Feb 10, 2020 · 5 comments
Open
1 of 3 tasks

suit: remove duplicate CoAP code #13330

bergzand opened this issue Feb 10, 2020 · 5 comments
Assignees
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: OTA Area: Over-the-air updates Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Comments

@bergzand
Copy link
Member

bergzand commented Feb 10, 2020

Description

From sys/include/suit/coap.h:

/*                                                                               
 * Dear Reviewer,                                                                
 *                                                                               
 * At the time of PR'ing this code, there was a pile of CoAP PR's waiting for    
 * reviews.  Some of that functionality is needed in one way or another for      
 * SUIT. In order to not block software updates with CoAP refactoring, some of   
 * the work-in-progress code has been copied here.  We expect this to be         
 * removed as soon as CoAP in master provides similar functionality.             
 *                                                                               
 * As this is internal code that will go soon, I exclude this from Doxygen.      
 *                                                                               
 * Kaspar (July 2019)                                                            
 */                                                                              

@kaspar I think it is time we start to clean this code up 😉.

Useful links

None

@bergzand bergzand added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: OTA Area: Over-the-air updates Area: CoAP Area: Constrained Application Protocol implementations labels Feb 10, 2020
@aabadie
Copy link
Contributor

aabadie commented Jul 2, 2020

@bergzand any plan soon to address the 2 remaining points ? ;)

@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jan 6, 2021
@stale stale bot closed this as completed Feb 9, 2021
@miri64
Copy link
Member

miri64 commented Feb 9, 2021

I guess this is still an issue, right?

@miri64 miri64 reopened this Feb 9, 2021
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Feb 9, 2021
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 2, 2022
@miri64
Copy link
Member

miri64 commented Mar 3, 2022

  • CoAP blockwise request callback

this was solved recently, right?

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: OTA Area: Over-the-air updates Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

No branches or pull requests

5 participants