Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link failures since 81cb769 #15357

Closed
larseggert opened this issue Nov 2, 2020 · 2 comments · Fixed by #15364
Closed

Link failures since 81cb769 #15357

larseggert opened this issue Nov 2, 2020 · 2 comments · Fixed by #15364
Assignees
Labels
Area: build system Area: Build system Area: pkg Area: External package ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@larseggert
Copy link
Contributor

Description

81cb769 broke the way I build quant for RIOT (confirmed via git bissect):

The link step doesn't seem to include the sources added to SRC, causing the link failure below. (The files do get compiled, just not linked.)

Steps to reproduce the issue

  1. git clone --shallow git@github.com:NTAP/quant.git
  2. git submodule update --init --recursive --depth 1
  3. cd riot
  4. set RIOTBASE correctly
  5. make BUILD_IN_DOCKER=1

Expected results

Expected the firmware to build and link.

Actual results

/data/riotbuild/riotproject/riot/bin/esp32-wroom-32/application_quant-client/main.o:(.text.startup.main+0x4): undefined reference to `quic_transaction'
/data/riotbuild/riotproject/riot/bin/esp32-wroom-32/application_quant-client/main.o: In function `main':
/data/riotbuild/riotproject/riot/main.c:40: undefined reference to `quic_transaction'
collect2: error: ld returned 1 exit status
/data/riotbuild/riotbase/Makefile.include:584: recipe for target '/data/riotbuild/riotproject/riot/bin/esp32-wroom-32/quant-client.elf' failed
make: *** [/data/riotbuild/riotproject/riot/bin/esp32-wroom-32/quant-client.elf] Error 1
make: *** [/Users/lars/Documents/Code/riot/makefiles/docker.inc.mk:304: ..in-docker-container] Error 2
@miri64 miri64 added Area: build system Area: Build system Area: pkg Area: External package ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 2, 2020
@leandrolanzieri
Copy link
Contributor

@larseggert thanks for reporting this. Could you give it a try with #15364?

@larseggert
Copy link
Contributor Author

#15364 fixes the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: pkg Area: External package ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants