Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6ln RA PIO with L flag set is not ignored #20377

Closed
xnumad opened this issue Feb 12, 2024 · 0 comments · Fixed by #20418
Closed

6ln RA PIO with L flag set is not ignored #20377

xnumad opened this issue Feb 12, 2024 · 0 comments · Fixed by #20418
Assignees
Labels
Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@xnumad
Copy link
Contributor

xnumad commented Feb 12, 2024

Description

(This was noticed because of the tests failing in #20371 )

A router MUST NOT set the L (on-link) flag in the PIOs, since that
might trigger hosts to send multicast NSs.

Should the host erroneously receive a PIO with the L (on-link) flag
set, then that PIO MUST be ignored.

The latter quote is not implemented in either tests or tested code.

Code implementation (tested code) adjustment would be a new PIO validity check failure condition: || (gnrc_netif_is_6ln(netif) && (pio->flags & NDP_OPT_PI_FLAGS_L))
Test adjustment is slightly more changes.

Steps to reproduce the issue

For example, observe failing tests in #20371

Expected results

These tests that currently fail in #20371 should not do so.

Actual results

They do fail.

Versions

Murdock on #20371

@xnumad xnumad changed the title 6ln RA PIO L flag tests wrong 6ln RA PIO with L flag set is not ignored Feb 22, 2024
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants