Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbus/dfu: cannot detach device to reboot into bootloader #20474

Closed
dylad opened this issue Mar 15, 2024 · 1 comment · Fixed by #20475
Closed

usbus/dfu: cannot detach device to reboot into bootloader #20474

dylad opened this issue Mar 15, 2024 · 1 comment · Fixed by #20475
Assignees
Labels
Area: USB Area: Universal Serial Bus Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@dylad
Copy link
Member

dylad commented Mar 15, 2024

Description

When dfu is in used, one can use dfu-util -e from a shell when the application is running to perform a reset into bootloader. (if USEMODULE=usbus_dfu) is present.
However, in current master, the operation fails.
It seems this regression was introduced by #17090.

Steps to reproduce the issue

Flash riotboot_dfu bootloader app:
make BOARD=same54-xpro -C bootloaders/riotboot_dfu flash
Flash an application on riotboot/slot0:
FEATURES_REQUIRED=riotboot PROGRAMMER=dfu-util USEMODULE=usbus_dfu make -j8 BOARD=same54-xpro -C tests/sys/shell riotboot/flash-slot0
Try to flash another application:
DFU_USB_ID=1209:7d00 FEATURES_REQUIRED=riotboot PROGRAMMER=dfu-util USEMODULE=usbus_dfu make -j8 BOARD=same54-xpro -C tests/leds riotboot/flash-slot1

Expected results

The last application should be flashed properly and running afterwards.

Actual results

Flashing fails because device doesn't reboot into bootloader.

@dylad dylad added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: USB Area: Universal Serial Bus labels Mar 15, 2024
@dylad
Copy link
Member Author

dylad commented Mar 16, 2024

I think I've identified the issue.
I'll prepare a patch in the following days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: USB Area: Universal Serial Bus Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants