Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: using old configuration with current scripts #4920

Closed
OlegHahm opened this issue Feb 28, 2016 · 4 comments
Closed

travis: using old configuration with current scripts #4920

OlegHahm opened this issue Feb 28, 2016 · 4 comments
Assignees
Labels
Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools Type: question The issue poses a question regarding usage of RIOT

Comments

@OlegHahm
Copy link
Member

The discussion in #4389 (comment) revealed that we have problem with older PRs if the Travis configuration and/or the test scripts change. One possible solution that I see, could be by parameterizing the build_and_test script with the branch name of the current build and let Travis run the version of the script that belongs to the currently checked PR.

@OlegHahm OlegHahm added Type: question The issue poses a question regarding usage of RIOT Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools labels Feb 28, 2016
@miri64
Copy link
Member

miri64 commented Feb 28, 2016

The problem why this arises is this rebase. Travis usually creates a merge commit with the current merge base on build creation (which means it doesn't change if the build is just restarted) so this rebase is most likely only there to catch errors that happen due to changes in master after build creation.

@miri64 miri64 closed this as completed Feb 28, 2016
@miri64 miri64 reopened this Feb 28, 2016
@miri64
Copy link
Member

miri64 commented Feb 28, 2016

Removing this rebase would result in exactly the behavior you proposed on the expense of breaking master due to errors that the version of s PR just wouldn't pick up because it uses an old version of master.

@miri64
Copy link
Member

miri64 commented Feb 28, 2016

I think I have an idea how to fix that, but first I go watch Deadpool now ;)

@miri64
Copy link
Member

miri64 commented Feb 29, 2016

The fix is now available at #4921 btw ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools Type: question The issue poses a question regarding usage of RIOT
Projects
None yet
Development

No branches or pull requests

2 participants