-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require_scim is problematic with Azure AD #20
Comments
Thanks for the report & link to the Azure AD issue - very useful. I've created #21 (currently under code review) which, if the comments made on the Azure AD ticket are correct, ought to fix things. I'll update this ticket once that gem version is pushed, so you can give it a try; or you could apply the PR's diff to your local code & test there in advance if you wish. |
V2.0.2 which hopefully fixes the issue is now published (https://rubygems.org/gems/scimitar). |
@kwent Please do let me know via this ticket if things look to be fixed in v2.0.2 - I'll close the ticket if so, else we'll work out next steps to try and fix up things for Azure AD. We developed this gem originally with an Azure AD client in mind, but in practice they ended up (partly, the ol' Covid reasons) not enabling that particular integration. So far, we've never actually had a "real" Azure AD caller come in - so your experience & bug report is very helpful. |
@pond will do ! Just need to port over your changes in my branch cause i'm still running on rails 6.0 |
Ah, yes. Fair. Would it help if I back-ported the fix onto the 1.x gem series? |
It would speed up the process for sure ! |
@kwent Well, assuming I didn't mess it up - I've not tried going back in time with Git tags & gem pushes before! - then https://rubygems.org/gems/scimitar is showing v1.2.1, which back-ports v2.0.1 and v2.0.2's fixes. |
@pond confirming that fixes the issue ! Thank you for your help so much :) |
That's great! Thanks for the issue & feedback. |
require_scim is problematic with Azure AD
See MicrosoftDocs/azure-docs#94189
My workaround for now: rootlyhq@2de2572
Wonder if there is a cleaner solution ?
Regards
The text was updated successfully, but these errors were encountered: