Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about default type in addresses #87

Closed
s-andringa opened this issue Nov 24, 2023 · 4 comments
Closed

Question about default type in addresses #87

s-andringa opened this issue Nov 24, 2023 · 4 comments

Comments

@s-andringa
Copy link

Hi @pond,

The address complex type's type sub-attribute's default value is 'work'. This surprised me, as it is not a required sub-attribute. And no other complex types have defaults for their sub-attributes. In this commit some have been removed from other complex types. Could it be that the address complex type was missed and should also be cleared of this default?

Thanks.

@pond
Copy link
Member

pond commented Jan 12, 2024

Yeah, I mean I'm a bit worried that this might constitute a breaking change for some clients but it's an odd default and given the commit you reference - and thank you very much for digging that up, super useful! - it does look like something that was overlooked.

@pond
Copy link
Member

pond commented Jan 12, 2024

@s-andringa #92

@pond
Copy link
Member

pond commented Jan 14, 2024

This is now in v2.7.0.

@pond pond closed this as completed Jan 14, 2024
@pond
Copy link
Member

pond commented Jan 15, 2024

...and v1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants