Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NAICS file to explicitly define every 6-digit code #103

Merged
merged 6 commits into from Jun 9, 2020
Merged

Update NAICS file to explicitly define every 6-digit code #103

merged 6 commits into from Jun 9, 2020

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jun 9, 2020

The sector bridge was misclassifying less granular NAICS codes of less than 6-digits. I explicitly defined every 6-digit code, and removed the code_level variable. This granular bridge should now correctly map any input classification code.

@jdhoffa jdhoffa requested a review from maurolepore June 9, 2020 12:36
Copy link
Contributor

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Would you like to push the patch 0.1.1 to CRAN ? It should go smoothly. Maybe it's a good excuse to refresh the workflow?

@maurolepore maurolepore merged commit 68d9bac into RMI-PACTA:master Jun 9, 2020
@jdhoffa
Copy link
Member Author

jdhoffa commented Jun 9, 2020

Ya lets do it!

@jdhoffa jdhoffa mentioned this pull request Jun 9, 2020
@jdhoffa jdhoffa deleted the 102-bugfix-naics branch June 18, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants