add etp region isos (#109) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXME: This is NOT DRY Just wanted to get a starting point.
This is just to be consistent with the rest of the packages, but I think I prefer the opposite direction -- to remove the namespace everywhere -- because that leaves less noise and helps me see what interesting patterns. ()I change my opinion about this way too often)
maurolepore
approved these changes
Jun 20, 2020
There was a problem hiding this comment.
Thanks Jackson!
I refactored the code to create region_isos and added edited NEWS.md to reflect this change.
Also I removed the namespace from calls to dplyr functions. Sorry for changing my mind about this. I think too many calls to dplyr:: obscure the interesting patterns.
Please have a look and change whatever you think necessary. In particularly, consider renaming the helpers so they make sense to you.
|
Sorry for the uninformative commits. I considered resubmitting a squashed version but that would be similar to squashing here. But I can do it if you prefer. I suggest you ignore the commit messages and only focus on the code. |
|
Sounds good, will have a look today or tomorrow |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added another region definition dictionary to the
region_isosfile, corresponding to the "Energy Technology Perspectives 2017" publication.Note: in the raw data sourcing file, there is some VERY WET work. I plan on working on this, but feel free to have a look right off the bat. Maybe we can do something similar to how we handle the classification files?
Closes #109