Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some nace_classification borderline sectors missing borderline = TRUE flag #213

Closed
jdhoffa opened this issue Feb 11, 2021 · 1 comment · Fixed by #214
Closed

Some nace_classification borderline sectors missing borderline = TRUE flag #213

jdhoffa opened this issue Feb 11, 2021 · 1 comment · Fixed by #214
Labels
bug an unexpected problem or unintended behavior

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 11, 2021

45.1, 45.11 and 45.19 are all related to the sale of motor vehicles. I believe that, however, owing to the misclassification of many loans, these should still be included as potentially having production, and should be identified with the borderline = TRUE flag.

Currently, the flag is FALSE

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(r2dii.data)

r2dii.data::nace_classification %>% 
  filter(sector == "automotive")
#> # A tibble: 6 x 5
#>   original_code code  code_level sector     borderline
#>   <chr>         <chr>      <dbl> <chr>      <lgl>     
#> 1 29.10         2910           4 automotive FALSE     
#> 2 29.20         2920           4 automotive TRUE      
#> 3 29.32         2932           4 automotive TRUE      
#> 4 45.1          451            3 automotive FALSE     
#> 5 45.11         4511           4 automotive FALSE     
#> 6 45.19         4519           4 automotive FALSE

Created on 2021-02-11 by the reprex package (v1.0.0)

@jdhoffa jdhoffa added the bug an unexpected problem or unintended behavior label Feb 11, 2021
@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 11, 2021

Thanks @KapitanKombajn for flagging this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant