feat: update `naics_classification` to latest version #355

jdhoffa · 2024-03-18T15:26:11Z

This PR updates the NAICS dataset to the latest version (published in "2022").

Relates to #344

@jacobvjk would appreciate a content review of this (especially on if some of these sectors should be Borderline). Steel in particular I was very unsure of.

jdhoffa · 2024-03-19T08:09:10Z

For posterity, the original raw data was pulled from here: https://www.census.gov/naics/?48967

jdhoffa · 2024-03-19T12:31:55Z

@jacobvjk updated the bridge to include all levels.
This PR is ready for review now

jacobvjk

A few changes I would suggest mostly relating to borderline inclusion.

In general, I am still unsure about how close to the core business we want a code to be in order to be considered borderline == TRUE. Especially in steel production there are a number of products that require high temperature furnaces in their processes. But I am unsure if this means that companies are often integrated

data-raw/classification_bridge.R

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

jdhoffa · 2024-03-19T14:39:35Z

EDIT: nevermind think I sorted it out

After applying the suggested changes, I get this weird case where certain "not in scope" sectors are also classified as "borderline = TRUE".

Any suggestion what I should do there?

jacobvjk

updated suggestions for steel based on https://www.transitionmonitor.com/wp-content/uploads/2020/09/steel_ef_final_pacta_banks_v1.2_14-09-2020.pdf and https://ieaghg.org/docs/General_Docs/Reports/PH3-30%20iron-steel.pdf

jacobvjk

somehow my latest steel suggestions were lost in the process

data-raw/classification_bridge.R

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

jacobvjk

some broader borderline definitions

data-raw/classification_bridge.R

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

jacobvjk

Last change. We validated that casting steel in foundries is in-scope and therefore these two codes should not be borderline

data-raw/classification_bridge.R

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

jacobvjk

lgtm

jdhoffa added 2 commits March 18, 2024 16:21

update NAICS classification to the latest revision

949ac87

update data dictionary and .rdas

20bd5a5

jdhoffa changed the title ~~344 update naics~~ feat: update naics_classification to latest version Mar 18, 2024

update NEWS.md

fc6bb13

jdhoffa requested a review from jacobvjk March 18, 2024 15:27

jdhoffa added 3 commits March 19, 2024 13:29

use 2-6-digit NAICS

a4564d0

update NAICS bridge

6a1e1d2

document

8fc7cd9

jacobvjk requested changes Mar 19, 2024

View reviewed changes

jacobvjk self-requested a review March 19, 2024 13:59

jdhoffa and others added 10 commits March 19, 2024 15:34

Update data-raw/classification_bridge.R

dc69d8f

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

b5c5613

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

01719f0

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

474c4a7

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

1c484dd

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

d1fe63c

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

bcadf96

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

493dcbf

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

7626eb8

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

aeca3c1

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

fix borderline = TRUE, not in scope

38e1bac

jacobvjk reviewed Mar 19, 2024

View reviewed changes

jdhoffa added 2 commits March 19, 2024 15:43

update sector_classifications

b1eff2d

document

34192d3

jacobvjk self-requested a review March 19, 2024 14:55

jacobvjk requested changes Mar 19, 2024

View reviewed changes

data-raw/classification_bridge.R Outdated Show resolved Hide resolved

data-raw/classification_bridge.R Show resolved Hide resolved

data-raw/classification_bridge.R Show resolved Hide resolved

Update data-raw/classification_bridge.R

c459994

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

jacobvjk self-requested a review March 19, 2024 15:45

jacobvjk requested changes Mar 19, 2024

View reviewed changes

jdhoffa and others added 18 commits March 20, 2024 09:25

Update data-raw/classification_bridge.R

878526c

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

8857da8

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

68f7eb4

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

82a1de1

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

94d3a0c

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

6ca173e

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

Update data-raw/classification_bridge.R

990b576

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

source data raw

d960ef1

update snaps

b9fc9e2

be more specific with automotive

895e99c

source data raw

9e4481b

update snaps

a4dd77b

Update data-raw/classification_bridge.R

6ecfa6c

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

refactor

f7a2a05

source data raw

c2dcc42

update sector_classifications

fc2290c

update snaps

9b7000c

refactor

c35b7b6

jdhoffa requested a review from jacobvjk March 20, 2024 08:46

Merge branch 'main' into 344-update_naics

59b5eb3

jacobvjk requested changes Mar 20, 2024

View reviewed changes

data-raw/classification_bridge.R Outdated Show resolved Hide resolved

jdhoffa and others added 3 commits March 20, 2024 10:55

Update data-raw/classification_bridge.R

23a578b

Co-authored-by: Jacob Kastl <60064070+jacobvjk@users.noreply.github.com>

source data raw

2ae9c62

update snaps

3ad25b9

jdhoffa requested a review from jacobvjk March 20, 2024 09:59

jacobvjk approved these changes Mar 20, 2024

View reviewed changes

jdhoffa merged commit e859959 into main Mar 20, 2024
24 checks passed

jdhoffa deleted the 344-update_naics branch March 20, 2024 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update `naics_classification` to latest version #355

feat: update `naics_classification` to latest version #355

jdhoffa commented Mar 18, 2024

jdhoffa commented Mar 19, 2024

jdhoffa commented Mar 19, 2024

jacobvjk left a comment

jdhoffa commented Mar 19, 2024 •

edited

jacobvjk left a comment

jacobvjk left a comment

jacobvjk left a comment

jacobvjk left a comment

jacobvjk left a comment

feat: update naics_classification to latest version #355

feat: update naics_classification to latest version #355

Conversation

jdhoffa commented Mar 18, 2024

jdhoffa commented Mar 19, 2024

jdhoffa commented Mar 19, 2024

jacobvjk left a comment

Choose a reason for hiding this comment

jdhoffa commented Mar 19, 2024 • edited

jacobvjk left a comment

Choose a reason for hiding this comment

jacobvjk left a comment

Choose a reason for hiding this comment

jacobvjk left a comment

Choose a reason for hiding this comment

jacobvjk left a comment

Choose a reason for hiding this comment

jacobvjk left a comment

Choose a reason for hiding this comment

feat: update `naics_classification` to latest version #355

feat: update `naics_classification` to latest version #355

jdhoffa commented Mar 19, 2024 •

edited