49 update region isos #50
Conversation
|
@jdhoffa, I see many lines overflow 80 characters -- which is a sane convention. Do you use a 80 character marker as a guide?
This seems like a minor issue but adds up to considerable effort. Many people like to keep their hands on the keyboard. |
|
Thanks @jdhoffa! It's looking good. I have a few more questions / comments: Are we okay to use data coming from a private source? |
|
btw we are ok to use this data publicly, yes! |
This commit simplifies the file structure and code to read a single raw region_isos dataset. This does the job for now so I prefer to keep it simple. But later we should need more complex code to store and read multiple raw datasets (I think one each year). When that happens we can revert this commit. Also the new name of the raw data to more closely follows the naming style of other datasets. The consistent prefix makes it easier to see that region_isos.R and region_isos_* are related.
This reverts commit 40b0333.
|
Thanks @jdhoffa! (Just to clarify, what you see above is silly, I pushed the 40b0333 then reverted it with 9642a28. The effect is obviously the same as to never push 40b0333 -- but I thought of this "patch" design after I pushed. Sorry for the confusion.) |
This is a draft since we will need to fix merge conflicts later when #48 is merged.
Closes #49