Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dataset region_isos_demo #60

Closed
jdhoffa opened this issue May 14, 2020 · 2 comments
Closed

New dataset region_isos_demo #60

jdhoffa opened this issue May 14, 2020 · 2 comments
Assignees

Comments

@jdhoffa
Copy link
Member

jdhoffa commented May 14, 2020

  • This dataset should be an exact duplicate of region_isos but with the column source equal to "demo_2020".

  • and filter region for c("global", "europe",...) plus a handful of sensible regions).

@maurolepore maurolepore changed the title Add dataset region_isos_demo New dataset region_isos_demo May 14, 2020
@maurolepore
Copy link
Contributor

maurolepore commented May 14, 2020

Add region_isos_demo

  • Starts not from a .csv but from the exported dataset region_isos.
  • Add "data-raw/data_dictionary/region_isos_demo.csv"
  • In "data-raw/region_isos_demo.R", add something like:
    region_isos_demo <- r2dii.data::region_isos %>%
         # code
    use_data(region_isos_demo, overwrite = TRUE)
    
  • usethis::use_r("region_isos_demo"). Document region_isos_demo
  • usethis::use_test("region_isos_demo"). Add regression tests of region_isos_demo
  • source("data-raw/data_dictionary.R"); devtools::load_all()
  • usethis::use_test("data_dictionary"). Test data_dictionary includes region_isos_demo

@maurolepore
Copy link
Contributor

Closed by #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants